netdev - Re: [PATCH net 1/1] qlcnic: Fix CPU soft lockup while collecting firmware dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200123.211358.7836836382214723.davem@davemloft.net>
Date:   Thu, 23 Jan 2020 21:13:58 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     manishc@...vell.com
Cc:     netdev@...r.kernel.org, GR-Linux-NIC-Dev@...vell.com
Subject: Re: [PATCH net 1/1] qlcnic: Fix CPU soft lockup while collecting
 firmware dump

From: Manish Chopra <manishc@...vell.com>
Date: Wed, 22 Jan 2020 01:43:38 -0800

> Driver while collecting firmware dump takes longer time to
> collect/process some of the firmware dump entries/memories.
> Bigger capture masks makes it worse as it results in larger
> amount of data being collected and results in CPU soft lockup.
> Place cond_resched() in some of the driver flows that are
> expectedly time consuming to relinquish the CPU to avoid CPU
> soft lockup panic.
> 
> Signed-off-by: Shahed Shaikh <shshaikh@...vell.com>
> Tested-by: Yonggen Xu <Yonggen.Xu@...l.com>
> Signed-off-by: Manish Chopra <manishc@...vell.com>

Applied.