netdev - Re: [PATCH net 0/3] net: fsl/fman: address erratum A011043

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <34f22df7-409a-43d1-3c59-52e6a32fbf17@gmail.com>
Date:   Thu, 23 Jan 2020 13:09:22 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     madalin.bucur@....nxp.com, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     robh+dt@...nel.org, mark.rutland@....com,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net 0/3] net: fsl/fman: address erratum A011043

On 1/22/20 5:20 AM, Madalin Bucur wrote:
> This addresses a HW erratum on some QorIQ DPAA devices.
> 
> MDIO reads to internal PCS registers may result in having
> the MDIO_CFG[MDIO_RD_ER] bit set, even when there is no
> error and read data (MDIO_DATA[MDIO_DATA]) is correct.
> Software may get false read error when reading internal
> PCS registers through MDIO. As a workaround, all internal
> MDIO accesses should ignore the MDIO_CFG[MDIO_RD_ER] bit.
> When the issue was present, one could see such errors
> during boot:
> 
>   mdio_bus ffe4e5000: Error while reading PHY0 reg at 3.3

Did you consider using the standard broken-turn-around property/support
and set your mii_bus::phy_ignore_ta_mask to all relevant bits?


> 
> Madalin Bucur (3):
>   dt-bindings: net: add fsl,erratum-a011043
>   powerpc/fsl/dts: add fsl,erratum-a011043
>   net/fsl: treat fsl,erratum-a011043
> 
>  Documentation/devicetree/bindings/net/fsl-fman.txt          | 13 +++++++++++++
>  .../boot/dts/fsl/qoriq-fman3-0-10g-0-best-effort.dtsi       |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-0-10g-0.dtsi          |  1 +
>  .../boot/dts/fsl/qoriq-fman3-0-10g-1-best-effort.dtsi       |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-0-10g-1.dtsi          |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-0.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-1.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-2.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-3.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-4.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-0-1g-5.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-1-10g-0.dtsi          |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-1-10g-1.dtsi          |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-0.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-1.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-2.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-3.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-4.dtsi           |  1 +
>  arch/powerpc/boot/dts/fsl/qoriq-fman3-1-1g-5.dtsi           |  1 +
>  drivers/net/ethernet/freescale/xgmac_mdio.c                 |  7 ++++++-
>  20 files changed, 37 insertions(+), 1 deletion(-)
> 


-- 
Florian