netdev - Re: [PATCH net-next v4 1/2] net: UDP tunnel encapsulation module for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 24 Jan 2020 21:30:21 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Martin Varghese <martinvarghesenokia@...il.com>
Cc:     kbuild-all@...ts.01.org, netdev@...r.kernel.org,
        davem@...emloft.net, corbet@....net, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, scott.drennan@...ia.com, jbenc@...hat.com,
        martin.varghese@...ia.com
Subject: Re: [PATCH net-next v4 1/2] net: UDP tunnel encapsulation module for

Hi Martin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on net/master linus/master v5.5-rc7 next-20200122]
[cannot apply to ipvs/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Martin-Varghese/Bare-UDP-L3-Encapsulation-Module/20200124-103044
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9bbc8be29d66cc34b650510f2c67b5c55235fe5d
config: openrisc-randconfig-a001-20200124 (attached as .config)
compiler: or1k-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=openrisc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from net/ipv4/ip_tunnel_core.c:27:
   include/net/ip6_tunnel.h: In function 'ip6tunnel_get_dst':
   include/net/ip6_tunnel.h:195:9: error: implicit declaration of function 'dst_cache_get_ip6'; did you mean 'dst_cache_get_ip4'? [-Werror=implicit-function-declaration]
     195 |   dst = dst_cache_get_ip6(dst_cache, &fl6->saddr);
         |         ^~~~~~~~~~~~~~~~~
         |         dst_cache_get_ip4
>> include/net/ip6_tunnel.h:195:7: warning: assignment to 'struct dst_entry *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     195 |   dst = dst_cache_get_ip6(dst_cache, &fl6->saddr);
         |       ^
   include/net/ip6_tunnel.h:213:3: error: implicit declaration of function 'dst_cache_set_ip6'; did you mean 'dst_cache_set_ip4'? [-Werror=implicit-function-declaration]
     213 |   dst_cache_set_ip6(dst_cache, dst, &fl6->saddr);
         |   ^~~~~~~~~~~~~~~~~
         |   dst_cache_set_ip4
   cc1: some warnings being treated as errors

vim +195 include/net/ip6_tunnel.h

   168	
   169	static inline struct dst_entry *ip6tunnel_get_dst(struct sk_buff *skb,
   170							  struct net_device *dev,
   171							  struct net *net,
   172							  struct socket *sock,
   173							  struct flowi6 *fl6,
   174							  const struct ip_tunnel_info *info,
   175							  bool use_cache)
   176	{
   177		struct dst_entry *dst = NULL;
   178	#ifdef CONFIG_DST_CACHE
   179		struct dst_cache *dst_cache;
   180	#endif
   181		__u8 prio;
   182	
   183		memset(fl6, 0, sizeof(*fl6));
   184		fl6->flowi6_mark = skb->mark;
   185		fl6->flowi6_proto = IPPROTO_UDP;
   186		fl6->daddr = info->key.u.ipv6.dst;
   187		fl6->saddr = info->key.u.ipv6.src;
   188		prio = info->key.tos;
   189	
   190		fl6->flowlabel = ip6_make_flowinfo(RT_TOS(prio),
   191						   info->key.label);
   192	#ifdef CONFIG_DST_CACHE
   193		dst_cache = (struct dst_cache *)&info->dst_cache;
   194		if (use_cache) {
 > 195			dst = dst_cache_get_ip6(dst_cache, &fl6->saddr);
   196			if (dst)
   197				return dst;
   198		}
   199	#endif
   200		dst = ipv6_stub->ipv6_dst_lookup_flow(net, sock->sk, fl6,
   201						      NULL);
   202		if (IS_ERR(dst)) {
   203			netdev_dbg(dev, "no route to %pI6\n", &fl6->daddr);
   204			return ERR_PTR(-ENETUNREACH);
   205		}
   206		if (dst->dev == dev) { /* is this necessary? */
   207			netdev_dbg(dev, "circular route to %pI6\n", &fl6->daddr);
   208			dst_release(dst);
   209			return ERR_PTR(-ELOOP);
   210		}
   211	#ifdef CONFIG_DST_CACHE
   212		if (use_cache)
   213			dst_cache_set_ip6(dst_cache, dst, &fl6->saddr);
   214	#endif
   215		return dst;
   216	}
   217	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (31804 bytes)