netdev - Re: [PATCH iproute2 1/6] json_print: Introduce print_#type_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200127055215.65e44719@hermes.lan>
Date:   Mon, 27 Jan 2020 05:52:15 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Ron Diskin <rondi@...lanox.com>
Cc:     David Ahern <dsahern@...il.com>, Jiri Pirko <jiri@...lanox.com>,
        Moshe Shemesh <moshe@...lanox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 1/6] json_print: Introduce
 print_#type_name_value

On Thu, 23 Jan 2020 12:32:26 +0200
Ron Diskin <rondi@...lanox.com> wrote:

> Until now print_#type functions supported printing constant names and
> unknown (variable) values only.
> Add functions to allow printing when the name is also sent to the
> function as a variable.
> 
> Signed-off-by: Ron Diskin <rondi@...lanox.com>
> Reviewed-by: Moshe Shemesh <moshe@...lanox.com>
> Reviewed-by: Jiri Pirko <jiri@...lanox.com>

Series applied.
I fixed one style complaint from checkpatch by removing semi-colon
in macro.

WARNING: macros should not use a trailing semicolon
#80: FILE: include/json_print.h:75:
+#define _PRINT_NAME_VALUE_FUNC(type_name, type, format_char)		  \
+	void print_##type_name##_name_value(const char *name, type value); \
+