netdev - Re: [PATCH] Revert "pktgen: Allow configuration of IPv6 source address range"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e64d45cb-62e8-70e3-2231-0138b3b7b740@zx2c4.com>
Date:   Mon, 27 Jan 2020 14:55:40 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     niu_xilei@....com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] Revert "pktgen: Allow configuration of IPv6 source
 address range"

On 1/27/20 1:51 PM, David Miller wrote:
>>> pktgen.c:(.text.mod_cur_headers+0xba0): undefined reference to `__umoddi3'

I assume this is caused by:

> -			prandom_bytes(&rand, sizeof(rand));
> -			rand = rand % (max6 - min6) + min6;

Rather than open coding the prandom range selection, it might be useful 
to grep the tree and see if there's a general use for prandom_range_u32 
and prandom_range_u64 or the like. If there's not, you can probably 
replace the % with a call to div64_u64_rem.