netdev - Re: [PATCH net-next v4] net/core: Replace driver version to be kernel version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <610dd4fb-4f7e-d3a6-cc75-7e4104dd8285@gmail.com>
Date:   Mon, 27 Jan 2020 09:43:52 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Leon Romanovsky <leon@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Michal Kubecek <mkubecek@...e.cz>,
        Shannon Nelson <snelson@...sando.io>
Cc:     Leon Romanovsky <leonro@...lanox.com>,
        Michal Kalderon <michal.kalderon@...vell.com>,
        linux-netdev <netdev@...r.kernel.org>,
        RDMA mailing list <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH net-next v4] net/core: Replace driver version to be kernel
 version

On 1/26/20 11:20 PM, Leon Romanovsky wrote:
>  net/ethtool/ioctl.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
> index 182bffbffa78..0501b615e920 100644
> --- a/net/ethtool/ioctl.c
> +++ b/net/ethtool/ioctl.c
> @@ -17,6 +17,7 @@
>  #include <linux/phy.h>
>  #include <linux/bitops.h>
>  #include <linux/uaccess.h>
> +#include <linux/vermagic.h>
>  #include <linux/vmalloc.h>
>  #include <linux/sfp.h>
>  #include <linux/slab.h>
> @@ -655,6 +656,7 @@ static noinline_for_stack int ethtool_get_drvinfo(struct net_device *dev,
> 
>  	memset(&info, 0, sizeof(info));
>  	info.cmd = ETHTOOL_GDRVINFO;
> +	strlcpy(info.version, UTS_RELEASE, sizeof(info.version));

This is much more reasonable, thanks for addressing everyone's concerns
Leon.
-- 
Florian