netdev - Re: [PATCH bpf] bpf: Reuse log from btf_prase_vmlinux() in btf_struct_ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEf4BzYONH0jpi+VV8Q72q2Uico2_MnydX0ptpcOJQLW8H+gng@mail.gmail.com>
Date:   Mon, 27 Jan 2020 10:34:42 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Martin KaFai Lau <kafai@...com>
Cc:     bpf <bpf@...r.kernel.org>, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        David Miller <davem@...emloft.net>,
        Kernel Team <kernel-team@...com>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf] bpf: Reuse log from btf_prase_vmlinux() in btf_struct_ops_init()

On Mon, Jan 27, 2020 at 9:52 AM Martin KaFai Lau <kafai@...com> wrote:
>
> Instead of using a locally defined "struct bpf_verifier_log log = {}",
> btf_struct_ops_init() should reuse the "log" from its calling
> function "btf_parse_vmlinux()".  It should also resolve the
> frame-size too large compiler warning in some ARCH.
>
> Fixes: 27ae7997a661 ("bpf: Introduce BPF_PROG_TYPE_STRUCT_OPS")
> Signed-off-by: Martin KaFai Lau <kafai@...com>
> ---

LGTM, but there is typo in subject (btf_prase_vmlinux).

Acked-by: Andrii Nakryiko <andriin@...com>

[...]