netdev - Re: [RFC PATCH 1/4] net/core: Introduce master_xmit_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f27d00e8-e6b5-51a2-fd70-5ed3e5f97610@amazon.com>
Date:   Wed, 29 Jan 2020 11:57:19 +0200
From:   Gal Pressman <galpress@...zon.com>
To:     Maor Gottlieb <maorg@...lanox.com>
CC:     <j.vosburgh@...il.com>, <vfalico@...il.com>, <andy@...yhouse.net>,
        <jiri@...lanox.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <saeedm@...lanox.com>,
        <jgg@...lanox.com>, <leonro@...lanox.com>, <alexr@...lanox.com>,
        <markz@...lanox.com>, <parav@...lanox.com>, <eranbe@...lanox.com>,
        <linux-rdma@...r.kernel.org>
Subject: Re: [RFC PATCH 1/4] net/core: Introduce master_xmit_slave_get

On 26/01/2020 15:21, Maor Gottlieb wrote:
> Add new ndo to get the xmit slave of master device.
> When slave selection method is based on hash, then the user can ask to
> get the xmit slave assume all the slaves can transmit by setting the
> LAG_FLAGS_HASH_ALL_SLAVES bit in the flags argument.
> 
> Signed-off-by: Maor Gottlieb <maorg@...lanox.com>
> ---
>  include/linux/netdevice.h |  3 +++
>  include/net/lag.h         | 19 +++++++++++++++++++
>  2 files changed, 22 insertions(+)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index 11bdf6cb30bd..faba4aa094e5 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1379,6 +1379,9 @@ struct net_device_ops {
>  						 struct netlink_ext_ack *extack);
>  	int			(*ndo_del_slave)(struct net_device *dev,
>  						 struct net_device *slave_dev);
> +	struct net_device*	(*ndo_xmit_slave_get)(struct net_device *master_dev,
> +						      struct sk_buff *skb,
> +						      int lag);

Hey Maor,
Should lag be named flags?
Also, better to use unsigned type for it.