netdev - Re: [RFC PATCH 1/4] net/core: Introduce master_xmit_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c72c634-14ef-3e24-6f83-6a1783170b83@mellanox.com>
Date:   Thu, 30 Jan 2020 15:40:18 +0000
From:   Maor Gottlieb <maorg@...lanox.com>
To:     Gal Pressman <galpress@...zon.com>
CC:     "j.vosburgh@...il.com" <j.vosburgh@...il.com>,
        "vfalico@...il.com" <vfalico@...il.com>,
        "andy@...yhouse.net" <andy@...yhouse.net>,
        Jiri Pirko <jiri@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        Alex Rosenbaum <alexr@...lanox.com>,
        Mark Zhang <markz@...lanox.com>,
        Parav Pandit <parav@...lanox.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: Re: [RFC PATCH 1/4] net/core: Introduce master_xmit_slave_get


On 1/29/2020 11:57 AM, Gal Pressman wrote:
> On 26/01/2020 15:21, Maor Gottlieb wrote:
>> Add new ndo to get the xmit slave of master device.
>> When slave selection method is based on hash, then the user can ask to
>> get the xmit slave assume all the slaves can transmit by setting the
>> LAG_FLAGS_HASH_ALL_SLAVES bit in the flags argument.
>>
>> Signed-off-by: Maor Gottlieb <maorg@...lanox.com>
>> ---
>>   include/linux/netdevice.h |  3 +++
>>   include/net/lag.h         | 19 +++++++++++++++++++
>>   2 files changed, 22 insertions(+)
>>
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index 11bdf6cb30bd..faba4aa094e5 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -1379,6 +1379,9 @@ struct net_device_ops {
>>   						 struct netlink_ext_ack *extack);
>>   	int			(*ndo_del_slave)(struct net_device *dev,
>>   						 struct net_device *slave_dev);
>> +	struct net_device*	(*ndo_xmit_slave_get)(struct net_device *master_dev,
>> +						      struct sk_buff *skb,
>> +						      int lag);
> Hey Maor,
> Should lag be named flags?
> Also, better to use unsigned type for it.

Yeah, will change it.