netdev - Re: [PATCH firmware] rtl_nic: add firmware files for RTL8153

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cea329a9-943b-7c15-ffb4-5e58b04d35e3@maciej.szmigiero.name>
Date:   Sat, 1 Feb 2020 23:56:49 +0100
From:   "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To:     Hayes Wang <hayeswang@...ltek.com>
Cc:     linux-firmware@...nel.org, netdev@...r.kernel.org,
        pmalani@...omium.org, grundler@...omium.org, nic_swsd@...ltek.com
Subject: Re: [PATCH firmware] rtl_nic: add firmware files for RTL8153

Hi Hayes,

On 23.10.2019 05:39, Hayes Wang wrote:
> This adds the firmware for Realtek RTL8153 Based USB Ethernet Adapters.
> 
> 1. Fix compatible issue for Asmedia hub.
> 2. Fix compatible issue for Compal platform.
> 3. Fix sometimes the device is lost after rebooting.
> 4. Improve the compatibility for EEE.
> 
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>
> ---
>  WHENCE                |  11 +++++++++++
>  rtl_nic/rtl8153a-2.fw | Bin 0 -> 1768 bytes
>  rtl_nic/rtl8153a-3.fw | Bin 0 -> 1440 bytes
>  rtl_nic/rtl8153a-4.fw | Bin 0 -> 712 bytes

This file fails to load for me:
thost kernel: [ T2503] r8152 1-3:1.0: unused bp5 is not zero
thost kernel: [ T2503] r8152 1-3:1.0: check USB firmware failed
thost kernel: [ T2503] r8152 1-3:1.0: unable to load firmware patch rtl_nic/rtl8153a-4.fw (-14)

Looking at the above file it has fw_mac->bp_num set to 5,
but fw_mac->bp[] array has 6 elements filled.

If I force fw_mac->bp_num to 6 in the code it loads successfully,
so perhaps it's a mistake in the firmware header?

Maciej