netdev - RE: [PATCH firmware] rtl_nic: add firmware files for RTL8153

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d0d5529f59e643338b7a9cf73f8e7f03@realtek.com>
Date:   Mon, 3 Feb 2020 07:13:15 +0000
From:   Hayes Wang <hayeswang@...ltek.com>
To:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
CC:     "linux-firmware@...nel.org" <linux-firmware@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "pmalani@...omium.org" <pmalani@...omium.org>,
        "grundler@...omium.org" <grundler@...omium.org>,
        nic_swsd <nic_swsd@...ltek.com>
Subject: RE: [PATCH firmware] rtl_nic: add firmware files for RTL8153

Maciej S. Szmigiero [mailto:mail@...iej.szmigiero.name]
> Sent: Sunday, February 02, 2020 6:57 AM
[...]
> This file fails to load for me:
> thost kernel: [ T2503] r8152 1-3:1.0: unused bp5 is not zero
> thost kernel: [ T2503] r8152 1-3:1.0: check USB firmware failed
> thost kernel: [ T2503] r8152 1-3:1.0: unable to load firmware patch
> rtl_nic/rtl8153a-4.fw (-14)
> 
> Looking at the above file it has fw_mac->bp_num set to 5,
> but fw_mac->bp[] array has 6 elements filled.
> 
> If I force fw_mac->bp_num to 6 in the code it loads successfully,
> so perhaps it's a mistake in the firmware header?

Yes. I updated the firmware and forgot to modify the bp_num
before releasing it. I will fix it. Thanks.

Best Regards,
Hayes