netdev - Re: [PATCH net] tls: handle NETDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200204.123041.1506575968362096923.davem@davemloft.net>
Date:   Tue, 04 Feb 2020 12:30:41 +0100 (CET)
From:   David Miller <davem@...emloft.net>
To:     raeds@...lanox.com
Cc:     john.fastabend@...il.com, daniel@...earbox.net, kuba@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] tls: handle NETDEV_UNREGISTER for tls device

From: Raed Salem <raeds@...lanox.com>
Date: Sun,  2 Feb 2020 13:22:52 +0200

> This patch to handle the asynchronous unregister
> device event so the device tls offload resources
> could be cleanly released.
> 
> Fixes: e8f69799810c ("net/tls: Add generic NIC offload infrastructure")
> Signed-off-by: Raed Salem <raeds@...lanox.com>
> Reviewed-by: Tariq Toukan <tariqt@...lanox.com>
> Reviewed-by: Saeed Mahameed <saeedm@...lanox.com>

As per Jakub's feedback, only devices which are UP can have TLS
rules installed to them.

Therefore we will always get the NETDEV_DOWN event first, to release
the TLS resources.

So I am tossing this patch.  If there is a real problem, you must
describe it in detail in the commit message.