netdev - RE: [PATCH net] tls: handle NETDEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM0PR05MB52507339607E5BF60372A878C4030@AM0PR05MB5250.eurprd05.prod.outlook.com>
Date:   Tue, 4 Feb 2020 13:07:47 +0000
From:   Raed Salem <raeds@...lanox.com>
To:     David Miller <davem@...emloft.net>
CC:     "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net] tls: handle NETDEV_UNREGISTER for tls device

Thanks David/Jakubs for the review,

I had problems with the setup, once I have results I resubmit on need.


> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Tuesday, February 04, 2020 1:31 PM
> To: Raed Salem <raeds@...lanox.com>
> Cc: john.fastabend@...il.com; daniel@...earbox.net; kuba@...nel.org;
> netdev@...r.kernel.org
> Subject: Re: [PATCH net] tls: handle NETDEV_UNREGISTER for tls device
> 
> From: Raed Salem <raeds@...lanox.com>
> Date: Sun,  2 Feb 2020 13:22:52 +0200
> 
> > This patch to handle the asynchronous unregister device event so the
> > device tls offload resources could be cleanly released.
> >
> > Fixes: e8f69799810c ("net/tls: Add generic NIC offload
> > infrastructure")
> > Signed-off-by: Raed Salem <raeds@...lanox.com>
> > Reviewed-by: Tariq Toukan <tariqt@...lanox.com>
> > Reviewed-by: Saeed Mahameed <saeedm@...lanox.com>
> 
> As per Jakub's feedback, only devices which are UP can have TLS rules
> installed to them.
> 
> Therefore we will always get the NETDEV_DOWN event first, to release the
> TLS resources.
> 
> So I am tossing this patch.  If there is a real problem, you must describe it in
> detail in the commit message.