netdev - Re: [PATCH ipsec v2] vti[6]: fix packet tx through bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <238cfe44-b8aa-ca4c-787a-c282117a405a@6wind.com>
Date:   Tue, 4 Feb 2020 14:10:56 +0100
From:   Nicolas Dichtel <nicolas.dichtel@...nd.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
Cc:     steffen.klassert@...unet.com, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH ipsec v2] vti[6]: fix packet tx through bpf_redirect() in
 XinY cases

Le 04/02/2020 à 12:46, Sabrina Dubroca a écrit :
[snip]
>> +#if IS_ENABLED(CONFIG_IPV6)
>> +		case htons(ETH_P_IPV6):
>> +			fl->u.ip6.flowi6_oif = dev->ifindex;
>> +			fl->u.ip6.flowi6_flags |= FLOWI_FLAG_ANYSRC;
>> +			dst = ip6_route_output(dev_net(dev), NULL, &fl->u.ip6);
> 
> I don't think that works with CONFIG_IPV6=m and CONFIG_NET_IPVTI=y:
> 
> ld: net/ipv4/ip_vti.o: in function `ip6_route_output':
> /home/sab/linux/net/./include/net/ip6_route.h:98: undefined reference to `ip6_route_output_flags'
:/

> 
> You probably have to do like ipvlan did in commit 7f897db37b76
> ("ipvlan: fix building with modular IPV6").
> 
Thanks for pointing this out.