netdev - Re: [PATCH] ptp_qoriq: add initialization message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 12 Feb 2020 12:45:53 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     "Y.b. Lu" <yangbo.lu@....com>
Cc:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "richardcochran@...il.com" <richardcochran@...il.com>
Subject: Re: [PATCH] ptp_qoriq: add initialization message

Hi Yangbo,

On Wed, 12 Feb 2020 at 12:39, Y.b. Lu <yangbo.lu@....com> wrote:
>
> > -----Original Message-----
> > From: Vladimir Oltean <olteanv@...il.com>
> > Sent: Wednesday, February 12, 2020 6:34 PM
> > To: Y.b. Lu <yangbo.lu@....com>
> > Cc: David Miller <davem@...emloft.net>; netdev@...r.kernel.org;
> > richardcochran@...il.com
> > Subject: Re: [PATCH] ptp_qoriq: add initialization message
> >
> > Hi Yangbo,
> >
> > On Wed, 12 Feb 2020 at 12:25, Y.b. Lu <yangbo.lu@....com> wrote:
> > >
> > > > -----Original Message-----
> > > > From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
> > > > Behalf Of David Miller
> > > > Sent: Wednesday, February 12, 2020 9:07 AM
> > > > To: Y.b. Lu <yangbo.lu@....com>
> > > > Cc: netdev@...r.kernel.org; richardcochran@...il.com
> > > > Subject: Re: [PATCH] ptp_qoriq: add initialization message
> > > >
> > > > From: Yangbo Lu <yangbo.lu@....com>
> > > > Date: Tue, 11 Feb 2020 12:50:53 +0800
> > > >
> > > > > It is necessary to print the initialization result.
> > > >
> > > > No, it is not.
> > >
> > > Sorry, I should have added my reasons into commit message.
> > > I sent out v2. Do you think if it makes sense?
> > >
> > > " Current ptp_qoriq driver prints only warning or error messages.
> > > It may be loaded successfully without any messages.
> > > Although this is fine, it would be convenient to have an oneline
> > > initialization log showing success and PTP clock index.
> > > The goods are,
> > > - The ptp_qoriq driver users may know whether this driver is loaded
> > >   successfully, or not, or not loaded from the booting log.
> > > - The ptp_qoriq driver users don't have to install an ethtool to
> > >   check the PTP clock index for using. Or don't have to check which
> > >   /sys/class/ptp/ptpX is PTP QorIQ clock."
> > >
> > > Thanks.
> >
> > How about this message which is already there?
> > [    2.603163] pps pps0: new PPS source ptp0
>
> This message is from pps subsystem. We don't know what PTP clock is registered as ptp0.
> And if the PTP clock doesn't support pps capability, even this log won't be showed.
>
> Thanks.
>
> >
> > Thanks,
> > -Vladimir

Yes but this is ptp_qoriq, which specifically _does_ support PPS, so
the message will be printed. Am I missing something?

Regards,
-Vladimir