netdev - Re: [Question] net: dsa: tag_qca: QCA tag and headroom size?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Feb 2020 05:23:59 +0000
From:   Per Förlin <Per.Forlin@...s.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "john@...ozen.org" <john@...ozen.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>
Subject: Re: [Question] net: dsa: tag_qca: QCA tag and headroom size?


> > -     if (skb_cow_head(skb, 0) < 0)
> > >  Is it really safe to assume there is enough headroom for the QCA tag?
> >
> > +     if (skb_cow_head(skb, QCA_HDR_LEN) < 0)
> > > My proposal. Specify QCA tag size to make sure there is headroom.
> >
> >               return NULL;
> >
> >       skb_push(skb, QCA_HDR_LEN);

> > Hi Per

> > Yes, your change looks correct. ar9331_tag_xmit() also seems to have
> > the same problem.

>> Do you want to submit a patch?
Thanks for your response,
I can submit a patch on both drivers, however I only have hardware to perform an actual test on the QCA switch.