netdev - Re: [Question] net: dsa: tag_qca: QCA tag and headroom size?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200213125332.GA2814@lunn.ch>
Date:   Thu, 13 Feb 2020 13:53:32 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Per Förlin <Per.Forlin@...s.com>
Cc:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "john@...ozen.org" <john@...ozen.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>
Subject: Re: [Question] net: dsa: tag_qca: QCA tag and headroom size?

On Thu, Feb 13, 2020 at 05:23:59AM +0000, Per Förlin wrote:
> 
> > > -     if (skb_cow_head(skb, 0) < 0)
> > > >  Is it really safe to assume there is enough headroom for the QCA tag?
> > >
> > > +     if (skb_cow_head(skb, QCA_HDR_LEN) < 0)
> > > > My proposal. Specify QCA tag size to make sure there is headroom.
> > >
> > >               return NULL;
> > >
> > >       skb_push(skb, QCA_HDR_LEN);
> 
> > > Hi Per
> 
> > > Yes, your change looks correct. ar9331_tag_xmit() also seems to have
> > > the same problem.
> 
> >> Do you want to submit a patch?
> Thanks for your response,

> I can submit a patch on both drivers, however I only have hardware
> to perform an actual test on the QCA switch.

Hi Per

That is fine. This should be low risk. Cc: Oleksij Rempel
<kernel@...gutronix.de> when you post the patch, so he can review and
test it.

Thanks
	Andrew