netdev - Re: [PATCH net 2/2] net: dsa: tag_ar9331: Make sure there is headroom for tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1c554fa-fde7-0e8b-959d-603e66db54b0@pengutronix.de>
Date:   Thu, 13 Feb 2020 14:59:58 +0100
From:   Oleksij Rempel <o.rempel@...gutronix.de>
To:     Per@...s.com, "\"Forlin" <"per.forlin\""@axis.co>,
        netdev@...r.kernel.org, andrew@...n.ch, davem@...emloft.net
Cc:     Per Forlin <per.forlin@...s.com>, Per Forlin <perfn@...s.com>
Subject: Re: [PATCH net 2/2] net: dsa: tag_ar9331: Make sure there is headroom
 for tag

Hi,

On 13.02.20 14:51, Per@...s.com wrote:
> From: Per Forlin <per.forlin@...s.com>
> 
> Passing tag size to skb_cow_head will make sure
> there is enough headroom for the tag data.
> This change does not introduce any overhead in case there
> is already available headroom for tag.
> 
> Signed-off-by: Per Forlin <perfn@...s.com>

Tested-by: Oleksij Rempel <o.rempel@...gutronix.de>

Thank you!

Are you using this driver?

> ---
>   net/dsa/tag_ar9331.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/dsa/tag_ar9331.c b/net/dsa/tag_ar9331.c
> index 466ffa92a474..55b00694cdba 100644
> --- a/net/dsa/tag_ar9331.c
> +++ b/net/dsa/tag_ar9331.c
> @@ -31,7 +31,7 @@ static struct sk_buff *ar9331_tag_xmit(struct sk_buff *skb,
>   	__le16 *phdr;
>   	u16 hdr;
>   
> -	if (skb_cow_head(skb, 0) < 0)
> +	if (skb_cow_head(skb, AR9331_HDR_LEN) < 0)
>   		return NULL;
>   
>   	phdr = skb_push(skb, AR9331_HDR_LEN);
> 

Kind regards,
Oleksij Rempel

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |