netdev - Re: [PATCH net 1/2] net: dsa: tag_qca: Make sure there is headroom for tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200213140132.GC12151@lunn.ch>
Date:   Thu, 13 Feb 2020 15:01:32 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Per@...s.com, Forlin <per.forlin@...s.com>
Cc:     netdev@...r.kernel.org, o.rempel@...gutronix.de,
        davem@...emloft.net, Per Forlin <per.forlin@...s.com>,
        Per Forlin <perfn@...s.com>
Subject: Re: [PATCH net 1/2] net: dsa: tag_qca: Make sure there is headroom
 for tag

On Thu, Feb 13, 2020 at 02:50:59PM +0100, Per@...s.com wrote:
> From: Per Forlin <per.forlin@...s.com>
> 
> Passing tag size to skb_cow_head will make sure
> there is enough headroom for the tag data.
> This change does not introduce any overhead in case there
> is already available headroom for tag.
> 
> Signed-off-by: Per Forlin <perfn@...s.com>

Hi Per

If these are for net, you need a Fixes: tag.

Also, you should add the Reivewed-by: tags i gave for these patches.

      Andrew