netdev - Re: [PATCH bpf v2] uapi/bpf: Remove text about bpf_redirect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e5210c2b-58b1-efae-80b5-ece62f067689@iogearbox.net>
Date:   Tue, 18 Feb 2020 15:33:29 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Toke Høiland-Jørgensen <toke@...hat.com>,
        ast@...com
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        David Ahern <dsahern@...il.com>,
        Quentin Monnet <quentin@...valent.com>
Subject: Re: [PATCH bpf v2] uapi/bpf: Remove text about bpf_redirect_map()
 giving higher performance

On 2/18/20 2:03 PM, Toke Høiland-Jørgensen wrote:
> The performance of bpf_redirect() is now roughly the same as that of
> bpf_redirect_map(). However, David Ahern pointed out that the header file
> has not been updated to reflect this, and still says that a significant
> performance increase is possible when using bpf_redirect_map(). Remove this
> text from the bpf_redirect_map() description, and reword the description in
> bpf_redirect() slightly. Also fix the 'Return' section of the
> bpf_redirect_map() documentation.
> 
> Fixes: 1d233886dd90 ("xdp: Use bulking for non-map XDP_REDIRECT and consolidate code paths")
> Reported-by: David Ahern <dsahern@...il.com>
> Reviewed-by: Quentin Monnet <quentin@...valent.com>
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>

Applied and also updated tools header, thanks!