netdev - Re: [PATCH bpf] libbpf: Sanitise internal map names so they are not rejected by the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9ddddbd6-aca2-61ae-b864-0f12d7fd33b4@iogearbox.net>
Date:   Tue, 18 Feb 2020 15:40:29 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Toke Høiland-Jørgensen <toke@...hat.com>,
        ast@...com
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH bpf] libbpf: Sanitise internal map names so they are not
 rejected by the kernel

On 2/17/20 6:17 PM, Toke Høiland-Jørgensen wrote:
> The kernel only accepts map names with alphanumeric characters, underscores
> and periods in their name. However, the auto-generated internal map names
> used by libbpf takes their prefix from the user-supplied BPF object name,
> which has no such restriction. This can lead to "Invalid argument" errors
> when trying to load a BPF program using global variables.
> 
> Fix this by sanitising the map names, replacing any non-allowed characters
> with underscores.
> 
> Fixes: d859900c4c56 ("bpf, libbpf: support global data/bss/rodata sections")
> Signed-off-by: Toke Høiland-Jørgensen <toke@...hat.com>

Makes sense to me, applied, thanks! I presume you had something like '-' in the
global var leading to rejection?