netdev - Re: [PATCH net-next 2/7] net/mlxfw: Improve FSM err message reporting and return codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200219222231.46425175@kicinski-fedora-PC1C0HJN>
Date:   Wed, 19 Feb 2020 22:22:31 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 2/7] net/mlxfw: Improve FSM err message
 reporting and return codes

On Thu, 20 Feb 2020 02:25:42 +0000 Saeed Mahameed wrote:
> Report unique and standard error codes corresponding to the specific
> FW flash error. In addition, add a more detailed error messages to
> netlink.
> 
> Before:
> $ devlink dev flash pci/0000:05:00.0 file ...
> Error: mlxfw: Firmware flash failed.
> devlink answers: Invalid argument
> 
> After:
> $ devlink dev flash pci/0000:05:00.0 file ...
> Error: mlxfw: Firmware flash failed: pending reset.
> devlink answers: Operation already in progress

That sounds incorrect, no? Isn't EBUSY more appropriate here?
The flash operation is not already in progress..

Also the ERR_ERROR could perhaps be simply -EIO?

Other than the error code selection the patches look good to me!

> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> Reviewed-by: Ido Schimmel <idosch@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>