netdev - Re: [PATCH net-next 2/7] net/mlxfw: Improve FSM err message reporting and return codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Feb 2020 21:18:25 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     "kuba@...nel.org" <kuba@...nel.org>
CC:     Eran Ben Elisha <eranbe@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH net-next 2/7] net/mlxfw: Improve FSM err message reporting
 and return codes

On Wed, 2020-02-19 at 22:22 -0800, Jakub Kicinski wrote:
> On Thu, 20 Feb 2020 02:25:42 +0000 Saeed Mahameed wrote:
> > Report unique and standard error codes corresponding to the
> > specific
> > FW flash error. In addition, add a more detailed error messages to
> > netlink.
> > 
> > Before:
> > $ devlink dev flash pci/0000:05:00.0 file ...
> > Error: mlxfw: Firmware flash failed.
> > devlink answers: Invalid argument
> > 
> > After:
> > $ devlink dev flash pci/0000:05:00.0 file ...
> > Error: mlxfw: Firmware flash failed: pending reset.
> > devlink answers: Operation already in progress
> 
> That sounds incorrect, no? Isn't EBUSY more appropriate here?
> The flash operation is not already in progress..
> 
> Also the ERR_ERROR could perhaps be simply -EIO?

Sounds good will change both. 

> 
> Other than the error code selection the patches look good to me!
> 
> > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> > Reviewed-by: Ido Schimmel <idosch@...lanox.com>
> > Acked-by: Jiri Pirko <jiri@...lanox.com>