netdev - RE: [PATCH bpf-next v7 03/11] tcp_bpf: Don't let child socket inherit parent protocol ops on copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e4f4e5dbc315_18d22b0a1febc5b82a@john-XPS-13-9370.notmuch>
Date:   Thu, 20 Feb 2020 19:28:29 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>, bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, kernel-team@...udflare.com,
        John Fastabend <john.fastabend@...il.com>,
        Lorenz Bauer <lmb@...udflare.com>, Martin Lau <kafai@...com>,
        eric.dumazet@...il.com
Subject: RE: [PATCH bpf-next v7 03/11] tcp_bpf: Don't let child socket inherit
 parent protocol ops on copy

Jakub Sitnicki wrote:
> Prepare for cloning listening sockets that have their protocol callbacks
> overridden by sk_msg. Child sockets must not inherit parent callbacks that
> access state stored in sk_user_data owned by the parent.
> 
> Restore the child socket protocol callbacks before it gets hashed and any
> of the callbacks can get invoked.
> 
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> ---

Looks reasonable to me. CC'ing Eric as well.

Acked-by: John Fastabend <john.fastabend@...il.com>