netdev - RE: [PATCH bpf-next v7 04/11] bpf, sockmap: Allow inserting listening TCP sockets into sockmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e4f4f8a876c8_18d22b0a1febc5b87e@john-XPS-13-9370.notmuch>
Date:   Thu, 20 Feb 2020 19:33:30 -0800
From:   John Fastabend <john.fastabend@...il.com>
To:     Jakub Sitnicki <jakub@...udflare.com>, bpf@...r.kernel.org
Cc:     netdev@...r.kernel.org, kernel-team@...udflare.com,
        John Fastabend <john.fastabend@...il.com>,
        Lorenz Bauer <lmb@...udflare.com>, Martin Lau <kafai@...com>
Subject: RE: [PATCH bpf-next v7 04/11] bpf, sockmap: Allow inserting listening
 TCP sockets into sockmap

Jakub Sitnicki wrote:
> In order for sockmap/sockhash types to become generic collections for
> storing TCP sockets we need to loosen the checks during map update, while
> tightening the checks in redirect helpers.
> 
> Currently sock{map,hash} require the TCP socket to be in established state,
> which prevents inserting listening sockets.
> 
> Change the update pre-checks so the socket can also be in listening state.
> 
> Since it doesn't make sense to redirect with sock{map,hash} to listening
> sockets, add appropriate socket state checks to BPF redirect helpers too.
> 
> Signed-off-by: Jakub Sitnicki <jakub@...udflare.com>
> ---

Acked-by: John Fastabend <john.fastabend@...il.com>