netdev - Re: [PATCH v2 1/3] dt-bindings: m_can: Add Documentation for transceiver regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Feb 2020 09:31:08 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Faiz Abbas <faiz_abbas@...com>, Rob Herring <robh@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-can@...r.kernel.org, broonie@...nel.org, lgirdwood@...il.com,
        catalin.marinas@....com, mark.rutland@....com, wg@...ndegger.com,
        sriram.dash@...sung.com, dmurphy@...com
Subject: Re: [PATCH v2 1/3] dt-bindings: m_can: Add Documentation for
 transceiver regulator

On 2/21/20 9:31 AM, Faiz Abbas wrote:
> Hi Rob,
> 
> On 20/02/20 2:05 am, Rob Herring wrote:
>> On Mon, Feb 17, 2020 at 07:58:34PM +0530, Faiz Abbas wrote:
>>> Some CAN transceivers have a standby line that needs to be asserted
>>> before they can be used. Model this GPIO lines as an optional
>>> fixed-regulator node. Document bindings for the same.
>>>
>>> Signed-off-by: Faiz Abbas <faiz_abbas@...com>
>>> ---
>>>  Documentation/devicetree/bindings/net/can/m_can.txt | 3 +++
>>>  1 file changed, 3 insertions(+)
>>
>> This has moved to DT schema in my tree, so please adjust it and resend.
> 
> Ok.
>>
>>> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt b/Documentation/devicetree/bindings/net/can/m_can.txt
>>> index ed614383af9c..f17e2a5207dc 100644
>>> --- a/Documentation/devicetree/bindings/net/can/m_can.txt
>>> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt
>>> @@ -48,6 +48,9 @@ Optional Subnode:
>>>  			  that can be used for CAN/CAN-FD modes. See
>>>  			  Documentation/devicetree/bindings/net/can/can-transceiver.txt
>>>  			  for details.
>>> +
>>> +- xceiver-supply: Regulator that powers the CAN transceiver.
>>
>> The supply for a transceiver should go in the transceiver node.
>>
> 
> Marc, while I have you here, do you agree with this?

I'll look into the details later today.

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |