netdev - Re: [patch net-next] iavf: use tc_cls_can_offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200225.132041.1071108395246034738.davem@davemloft.net>
Date:   Tue, 25 Feb 2020 13:20:41 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jeffrey.t.kirsher@...el.com
Cc:     jiri@...nulli.us, netdev@...r.kernel.org, kuba@...nel.org,
        intel-wired-lan@...ts.osuosl.org
Subject: Re: [patch net-next] iavf: use tc_cls_can_offload_basic() instead
 of chain check

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 25 Feb 2020 13:15:46 -0800

> On Tue, 2020-02-25 at 13:10 +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> Looks like the iavf code actually experienced a race condition, when
>> a
>> developer took code before the check for chain 0 was put to helper.
>> So use tc_cls_can_offload_basic() helper instead of direct check and
>> move the check to _cb() so this is similar to i40e code.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> 
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> 
> Go ahead and pick this up Dave, thanks!

Hmmm, Jiri this doesn't compile?

  CC [M]  drivers/net/ethernet/intel/iavf/iavf_main.o
drivers/net/ethernet/intel/iavf/iavf_main.c: In function ‘iavf_setup_tc_block_cb’:
drivers/net/ethernet/intel/iavf/iavf_main.c:3089:7: error: implicit declaration of function ‘tc_cls_can_offload_basic’; did you mean ‘tc_cls_common_offload_init’? [-Werror=implicit-function-declaration]
  if (!tc_cls_can_offload_basic(adapter->netdev, type_data))
       ^~~~~~~~~~~~~~~~~~~~~~~~
       tc_cls_common_offload_init

Maybe it does depend upon something in the tc filter patch series?