netdev - Re: [patch net-next] iavf: use tc_cls_can_offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200226073602.GB10533@nanopsycho>
Date:   Wed, 26 Feb 2020 08:36:02 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     David Miller <davem@...emloft.net>
Cc:     jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
        kuba@...nel.org, intel-wired-lan@...ts.osuosl.org
Subject: Re: [patch net-next] iavf: use tc_cls_can_offload_basic() instead of
 chain check

Tue, Feb 25, 2020 at 10:20:41PM CET, davem@...emloft.net wrote:
>From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>Date: Tue, 25 Feb 2020 13:15:46 -0800
>
>> On Tue, 2020-02-25 at 13:10 +0100, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@...lanox.com>
>>> 
>>> Looks like the iavf code actually experienced a race condition, when
>>> a
>>> developer took code before the check for chain 0 was put to helper.
>>> So use tc_cls_can_offload_basic() helper instead of direct check and
>>> move the check to _cb() so this is similar to i40e code.
>>> 
>>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>> 
>> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>> 
>> Go ahead and pick this up Dave, thanks!
>
>Hmmm, Jiri this doesn't compile?

Crap :/ I shuffled with the patches too much. Will send v2. Sorry.

>
>  CC [M]  drivers/net/ethernet/intel/iavf/iavf_main.o
>drivers/net/ethernet/intel/iavf/iavf_main.c: In function ‘iavf_setup_tc_block_cb’:
>drivers/net/ethernet/intel/iavf/iavf_main.c:3089:7: error: implicit declaration of function ‘tc_cls_can_offload_basic’; did you mean ‘tc_cls_common_offload_init’? [-Werror=implicit-function-declaration]
>  if (!tc_cls_can_offload_basic(adapter->netdev, type_data))
>       ^~~~~~~~~~~~~~~~~~~~~~~~
>       tc_cls_common_offload_init
>
>Maybe it does depend upon something in the tc filter patch series?