netdev - re: net: UDP tunnel encapsulation module for tunnelling different

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a8cabb8-e371-d119-c2e6-d495eca016b7@canonical.com>
Date:   Tue, 25 Feb 2020 23:04:56 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Martin Varghese <martin.varghese@...ia.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: re: net: UDP tunnel encapsulation module for tunnelling different

Hi,

Static analysis with Coverity detected an issue in function
bareudp_xmit_skb with the return of an uninitialized value in variable
err in the following commit:

commit 571912c69f0ed731bd1e071ade9dc7ca4aa52065
Author: Martin Varghese <martin.varghese@...ia.com>
Date:   Mon Feb 24 10:57:50 2020 +0530

    net: UDP tunnel encapsulation module for tunnelling different
protocols like MPLS, IP, NSH etc.

The analysis is as follows:

var_decl: Declaring variable err without initializer.

301        int err;
302

...

344 free_dst:
345        dst_release(&rt->dst);

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value err.

346        return err;
347 }

and also in function bareudp6_xmit_skb:

var_decl: Declaring variable err without initializer.

364        int err;
365

...

404
405 free_dst:
406        dst_release(dst);

Uninitialized scalar variable (UNINIT)
uninit_use: Using uninitialized value err.

407        return err;
408 }

Colin