netdev - Re: [patch net-next 10/10] selftests: netdevsim: Extend devlink trap test to include flow action cookie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200225074603.GC17869@nanopsycho>
Date:   Tue, 25 Feb 2020 08:46:03 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nhorman@...driver.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, idosch@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [patch net-next 10/10] selftests: netdevsim: Extend devlink trap
 test to include flow action cookie

Tue, Feb 25, 2020 at 05:43:32AM CET, kuba@...nel.org wrote:
>On Mon, 24 Feb 2020 22:07:58 +0100, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> Extend existing devlink trap test to include metadata type for flow
>> action cookie.
>> 
>> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
>> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
>> ---
>>  .../testing/selftests/drivers/net/netdevsim/devlink_trap.sh  | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh b/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh
>> index f101ab9441e2..437d32bd4cfd 100755
>> --- a/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh
>> +++ b/tools/testing/selftests/drivers/net/netdevsim/devlink_trap.sh
>> @@ -103,6 +103,11 @@ trap_metadata_test()
>>  	for trap_name in $(devlink_traps_get); do
>>  		devlink_trap_metadata_test $trap_name "input_port"
>>  		check_err $? "Input port not reported as metadata of trap $trap_name"
>> +		if [ $trap_name == "ingress_flow_action_drop" ] ||
>> +		   [ $trap_name == "egress_flow_action_drop" ]; then
>> +			devlink_trap_metadata_test $trap_name "flow_action_cookie"
>> +			check_err $? "Flow action cookie not reported as metadata of trap $trap_name"
>> +		fi
>>  	done
>>  
>>  	log_test "Trap metadata"
>
>Oh, this doesn't seem to check the contents of the trap at all, does it?

No. This is not the test for the actual trapped packets. It is a test to
list devlink traps and supported metadata.

The packet trapping is done using dropmonitor which is currently
not implemented in selftests, even for the existing traps. Not even for
mlxsw. There is a plan to introduce these tests in the future, Ido is
working on a tool to catch those packets to pcap using dropmon. I think
he plans to send it to dropmon git soon. Then we can implement the
selftests using it.