netdev - Re: [patch net-next 09/10] netdevsim: add ACL trap reporting cookie as a metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200225095315.40b94e73@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 25 Feb 2020 09:53:15 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, nhorman@...driver.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, idosch@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [patch net-next 09/10] netdevsim: add ACL trap reporting cookie
 as a metadata

On Tue, 25 Feb 2020 08:40:19 +0100 Jiri Pirko wrote:
> >Also I feel like we could just hold onto the ASCII hex buf, 
> >and simplify the reading side. If the hex part is needed in 
> >the first place, hexdump and xxd exist..  
> 
> I don't understand. Do you suggest to keep the write hex "buf" as well
> and just print it out in "read()" function? I don't like to store one
> info in 2 places. We need to have the cookie in fa_cookie anyway. Easy
> to bin2hex from it and send to userspace.

Okay, no strong feelings. I did not like the GFP_ATOMIC allocation on
read, just to convert formats. But it's not a big deal.

Thanks for the adjustments!