netdev - Re: [PATCH RFC net-next] virtio_net: Relax queue requirement for using XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200226043219-mutt-send-email-mst@kernel.org>
Date:   Wed, 26 Feb 2020 04:32:47 -0500
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     David Ahern <dsahern@...il.com>, Jason Wang <jasowang@...hat.com>,
        David Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
        davem@...emloft.net, kuba@...nel.org,
        David Ahern <dahern@...italocean.com>
Subject: Re: [PATCH RFC net-next] virtio_net: Relax queue requirement for
 using XDP

On Wed, Feb 26, 2020 at 10:02:03AM +0100, Toke Høiland-Jørgensen wrote:
> "Michael S. Tsirkin" <mst@...hat.com> writes:
> 
> > On Wed, Feb 26, 2020 at 09:34:51AM +0100, Toke Høiland-Jørgensen wrote:
> >> we already do block some reconfiguration if an XDP program is loaded
> >> (such as MTU changes), so there is some precedence for that :)
> > Do we really block MTU changes when XDP is loaded?
> > Seems to work for me - there's a separate discussion going
> > on about how to handle MTU changes - see
> > https://lore.kernel.org/r/7df5bb7f-ea69-7673-642b-f174e45a1e64@digitalocean.com
> > 	virtio_net: can change MTU after installing program
> 
> Maybe not for virtio_net, but that same thing doesn't work on mlx5:
> 
> $ sudo ip link set dev ens1f1 mtu 8192
> RTNETLINK answers: Invalid argument
> 
> -Toke

Let's take it to that thread please. I'll CC you.

-- 
MST