netdev - Re: [RFC] slip: not call free_netdev before rtnl_unlock in slip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cfc612e7-5eb4-16b0-30f6-32d7d4daec29@huawei.com>
Date:   Wed, 26 Feb 2020 20:01:28 +0800
From:   yangerkun <yangerkun@...wei.com>
To:     Oliver Hartkopp <socketcan@...tkopp.net>,
        David Miller <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <maowenan@...wei.com>
Subject: Re: [RFC] slip: not call free_netdev before rtnl_unlock in slip_open



On 2020/2/26 15:28, Oliver Hartkopp wrote:
> 
> 
> On 26/02/2020 04.30, David Miller wrote:
>> From: yangerkun <yangerkun@...wei.com>
>> Date: Wed, 26 Feb 2020 09:35:38 +0800
>>
>>>
>>>
>>> On 2020/2/26 2:39, David Miller wrote:
>>>> From: yangerkun <yangerkun@...wei.com>
>>>> Date: Tue, 25 Feb 2020 16:57:16 +0800
>>>>
>>>>> Ping. And anyone can give some advise about this patch?
>>>> You've pinged us 5 or 6 times already.
>>> Hi,
>>>
>>> Thanks for your reply!
>>>
>>> I am so sorry for the frequently ping which can make some
>>> noise. Wont't happen again after this...
>>
>> Ok.  But please repost your patch without the RFC tag.
>>
> 
> In fact the comment
> 
> /* do not call free_netdev before rtnl_unlock */
> 
> is also obsolete and can be omitted as you describe the change in the 
> commit message.

Hi,

Yes. No need for this commit message. I will resend the patch!

Thanks,
Kun.

> 
> In similar code snipets in the kernel there are also no comments for this.
> 
> Thanks,
> Oliver
> 
>