netdev - Re: [RFC] slip: not call free_netdev before rtnl_unlock in slip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8654b2ef-1951-7f10-c09d-8f42beee9cd4@hartkopp.net>
Date:   Wed, 26 Feb 2020 08:28:55 +0100
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     David Miller <davem@...emloft.net>, yangerkun@...wei.com
Cc:     netdev@...r.kernel.org, maowenan@...wei.com
Subject: Re: [RFC] slip: not call free_netdev before rtnl_unlock in slip_open



On 26/02/2020 04.30, David Miller wrote:
> From: yangerkun <yangerkun@...wei.com>
> Date: Wed, 26 Feb 2020 09:35:38 +0800
> 
>>
>>
>> On 2020/2/26 2:39, David Miller wrote:
>>> From: yangerkun <yangerkun@...wei.com>
>>> Date: Tue, 25 Feb 2020 16:57:16 +0800
>>>
>>>> Ping. And anyone can give some advise about this patch?
>>> You've pinged us 5 or 6 times already.
>> Hi,
>>
>> Thanks for your reply!
>>
>> I am so sorry for the frequently ping which can make some
>> noise. Wont't happen again after this...
> 
> Ok.  But please repost your patch without the RFC tag.
> 

In fact the comment

/* do not call free_netdev before rtnl_unlock */

is also obsolete and can be omitted as you describe the change in the 
commit message.

In similar code snipets in the kernel there are also no comments for this.

Thanks,
Oliver