netdev - Re: [patch net-next v2] iavf: use tc_cls_can_offload_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200226.090153.917262074842828253.davem@davemloft.net>
Date:   Wed, 26 Feb 2020 09:01:53 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     jiri@...nulli.us
Cc:     netdev@...r.kernel.org, kuba@...nel.org,
        jeffrey.t.kirsher@...el.com, intel-wired-lan@...ts.osuosl.org
Subject: Re: [patch net-next v2] iavf: use tc_cls_can_offload_and_chain0()
 instead of chain check

From: Jiri Pirko <jiri@...nulli.us>
Date: Wed, 26 Feb 2020 09:21:57 +0100

> From: Jiri Pirko <jiri@...lanox.com>
> 
> Looks like the iavf code actually experienced a race condition, when a
> developer took code before the check for chain 0 was put to helper.
> So use tc_cls_can_offload_and_chain0() helper instead of direct check and
> move the check to _cb() so this is similar to i40e code.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
> v1->v2:
> - rebased on top of net-next (using the correct helper name)

Applied, thanks Jiri.