netdev - Re: [patch net-next v2 02/12] ocelot_flower: use flow_offload_has_one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+h21hpuBWDZ4WoE70+LB6uS=fUo+DgezqRFw4UT=v56pCXApQ@mail.gmail.com>
Date:   Sat, 29 Feb 2020 02:50:06 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev <netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, saeedm@...lanox.com,
        leon@...nel.org, michael.chan@...adcom.com, vishal@...lsio.com,
        Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Ido Schimmel <idosch@...lanox.com>, aelior@...vell.com,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>, pablo@...filter.org,
        Edward Cree <ecree@...arflare.com>, mlxsw@...lanox.com
Subject: Re: [patch net-next v2 02/12] ocelot_flower: use flow_offload_has_one_action()
 helper

On Fri, 28 Feb 2020 at 19:25, Jiri Pirko <jiri@...nulli.us> wrote:
>
> From: Jiri Pirko <jiri@...lanox.com>
>
> Instead of directly checking number of action entries, use
> flow_offload_has_one_action() helper.
>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---

Acked-by: Vladimir Oltean <vladimir.oltean@....com>

> v1->v2:
> - new patch
> ---
>  drivers/net/ethernet/mscc/ocelot_flower.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mscc/ocelot_flower.c b/drivers/net/ethernet/mscc/ocelot_flower.c
> index 3d65b99b9734..b85111dcc2be 100644
> --- a/drivers/net/ethernet/mscc/ocelot_flower.c
> +++ b/drivers/net/ethernet/mscc/ocelot_flower.c
> @@ -19,7 +19,7 @@ static int ocelot_flower_parse_action(struct flow_cls_offload *f,
>         const struct flow_action_entry *a;
>         int i;
>
> -       if (f->rule->action.num_entries != 1)
> +       if (!flow_offload_has_one_action(&f->rule->action))
>                 return -EOPNOTSUPP;
>
>         flow_action_for_each(i, a, &f->rule->action) {
> --
> 2.21.1
>