netdev - Re: [patch net-next v2 03/12] flow_offload: check for basic action hw stats type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200229074004.GL26061@nanopsycho>
Date:   Sat, 29 Feb 2020 08:40:04 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, saeedm@...lanox.com,
        leon@...nel.org, michael.chan@...adcom.com, vishal@...lsio.com,
        jeffrey.t.kirsher@...el.com, idosch@...lanox.com,
        aelior@...vell.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, jhs@...atatu.com,
        xiyou.wangcong@...il.com, pablo@...filter.org,
        ecree@...arflare.com, mlxsw@...lanox.com
Subject: Re: [patch net-next v2 03/12] flow_offload: check for basic action
 hw stats type

Fri, Feb 28, 2020 at 08:40:56PM CET, kuba@...nel.org wrote:
>On Fri, 28 Feb 2020 18:24:56 +0100 Jiri Pirko wrote:
>> @@ -299,6 +300,9 @@ static int bnxt_tc_parse_actions(struct bnxt *bp,
>>  		return -EINVAL;
>>  	}
>>  
>> +	if (!flow_action_basic_hw_stats_types_check(flow_action, extack))
>> +		return -EOPNOTSUPP;
>
>Could we have this helper take one stat type? To let drivers pass the
>stat type they support? 

That would be always "any" as "any" is supported by all drivers.
And that is exactly what the helper checks..


>
>At some point we should come up with a way to express the limitations
>at callback registration time so we don't need to add checks like this
>to all the drivers. On the TODO list it goes :)

I was thinking about that. Not really easy with the currect infra.

>
>>  	flow_action_for_each(i, act, flow_action) {
>>  		switch (act->id) {
>>  		case FLOW_ACTION_DROP:
>