netdev - Re: [PATCHv2 net] net/ipv6: use configured metric when add peer route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 29 Feb 2020 21:56:35 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     liuhangbin@...il.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com, jishi@...hat.com,
        roopa@...ulusnetworks.com
Subject: Re: [PATCHv2 net] net/ipv6: use configured metric when add peer
 route

From: Hangbin Liu <liuhangbin@...il.com>
Date: Sat, 29 Feb 2020 17:27:13 +0800

> When we add peer address with metric configured, IPv4 could set the dest
> metric correctly, but IPv6 do not. e.g.
> 
> ]# ip addr add 192.0.2.1 peer 192.0.2.2/32 dev eth1 metric 20
> ]# ip route show dev eth1
> 192.0.2.2 proto kernel scope link src 192.0.2.1 metric 20
> ]# ip addr add 2001:db8::1 peer 2001:db8::2/128 dev eth1 metric 20
> ]# ip -6 route show dev eth1
> 2001:db8::1 proto kernel metric 20 pref medium
> 2001:db8::2 proto kernel metric 256 pref medium
> 
> Fix this by using configured metric instead of default one.
> 
> Reported-by: Jianlin Shi <jishi@...hat.com>
> Fixes: 8308f3ff1753 ("net/ipv6: Add support for specifying metric of connected routes")
> Reviewed-by: David Ahern <dsahern@...il.com>
> Signed-off-by: Hangbin Liu <liuhangbin@...il.com>
> 
> ---
> v2: fix metric typo

Applied and queued up for -stable, thank you.