netdev - Re: [PATCH net] net: dsa: sja1105: Don't destroy not-yet-created xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200229.215934.1263272461754132496.davem@davemloft.net>
Date:   Sat, 29 Feb 2020 21:59:34 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     olteanv@...il.com
Cc:     f.fainelli@...il.com, vivien.didelot@...il.com, andrew@...n.ch,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: sja1105: Don't destroy not-yet-created
 xmit_worker

From: Vladimir Oltean <olteanv@...il.com>
Date: Sat, 29 Feb 2020 22:30:07 +0200

> Fixes the following NULL pointer dereference on PHY connect error path
> teardown:
 ...
> Checking for NULL pointer is correct because the per-port xmit kernel
> threads are created in sja1105_probe immediately after calling
> dsa_register_switch.
> 
> Fixes: a68578c20a96 ("net: dsa: Make deferred_xmit private to sja1105")
> Signed-off-by: Vladimir Oltean <olteanv@...il.com>

Applied, thank you.