netdev - Re: [PATCH v4 09/10] PCI: pci-bridge-emul: Use new constant PCI_STATUS_ERROR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200304134444.GA198415@google.com>
Date:   Wed, 4 Mar 2020 07:44:44 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Realtek linux nic maintainers <nic_swsd@...ltek.com>,
        David Miller <davem@...emloft.net>,
        Mirko Lindner <mlindner@...vell.com>,
        Stephen Hemminger <stephen@...workplumber.org>,
        Clemens Ladisch <clemens@...isch.de>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        alsa-devel@...a-project.org
Subject: Re: [PATCH v4 09/10] PCI: pci-bridge-emul: Use new constant
 PCI_STATUS_ERROR_BITS

On Sat, Feb 29, 2020 at 11:28:18PM +0100, Heiner Kallweit wrote:
> Use new constant PCI_STATUS_ERROR_BITS to simplify the code.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

> ---
>  drivers/pci/pci-bridge-emul.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c
> index fffa77093..4f4f54bc7 100644
> --- a/drivers/pci/pci-bridge-emul.c
> +++ b/drivers/pci/pci-bridge-emul.c
> @@ -50,12 +50,7 @@ static const struct pci_bridge_reg_behavior pci_regs_behavior[] = {
>  		       (PCI_STATUS_CAP_LIST | PCI_STATUS_66MHZ |
>  			PCI_STATUS_FAST_BACK | PCI_STATUS_DEVSEL_MASK) << 16),
>  		.rsvd = GENMASK(15, 10) | ((BIT(6) | GENMASK(3, 0)) << 16),
> -		.w1c = (PCI_STATUS_PARITY |
> -			PCI_STATUS_SIG_TARGET_ABORT |
> -			PCI_STATUS_REC_TARGET_ABORT |
> -			PCI_STATUS_REC_MASTER_ABORT |
> -			PCI_STATUS_SIG_SYSTEM_ERROR |
> -			PCI_STATUS_DETECTED_PARITY) << 16,
> +		.w1c = PCI_STATUS_ERROR_BITS << 16,
>  	},
>  	[PCI_CLASS_REVISION / 4] = { .ro = ~0 },
>  
> @@ -100,12 +95,7 @@ static const struct pci_bridge_reg_behavior pci_regs_behavior[] = {
>  			 PCI_STATUS_DEVSEL_MASK) << 16) |
>  		       GENMASK(11, 8) | GENMASK(3, 0)),
>  
> -		.w1c = (PCI_STATUS_PARITY |
> -			PCI_STATUS_SIG_TARGET_ABORT |
> -			PCI_STATUS_REC_TARGET_ABORT |
> -			PCI_STATUS_REC_MASTER_ABORT |
> -			PCI_STATUS_SIG_SYSTEM_ERROR |
> -			PCI_STATUS_DETECTED_PARITY) << 16,
> +		.w1c = PCI_STATUS_ERROR_BITS << 16,
>  
>  		.rsvd = ((BIT(6) | GENMASK(4, 0)) << 16),
>  	},
> -- 
> 2.25.1
> 
>