| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 4 Mar 2020 13:15:54 -0800
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: mkubecek@...e.cz, thomas.lendacky@....com, benve@...co.com,
_govind@....com, pkaustub@...co.com, peppe.cavallaro@...com,
alexandre.torgue@...com, joabreu@...opsys.com, snelson@...sando.io,
yisen.zhuang@...wei.com, salil.mehta@...wei.com,
jeffrey.t.kirsher@...el.com, alexander.h.duyck@...ux.intel.com,
michael.chan@...adcom.com, saeedm@...lanox.com, leon@...nel.org,
netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 01/12] ethtool: add infrastructure for
centralized checking of coalescing parameters
On 3/3/2020 8:33 PM, Jakub Kicinski wrote:
> Linux supports 22 different interrupt coalescing parameters.
> No driver implements them all. Some drivers just ignore the
> ones they don't support, while others have to carry a long
> list of checks to reject unsupported settings.
> > To simplify the drivers add the ability to specify inside
> ethtool_ops which parameters are supported and let the core
> reject attempts to set any other one.
>
Nice!
Seems straight forward to me.
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> This commit makes the mechanism an opt-in, only drivers which
> set ethtool_opts->coalesce_types to a non-zero value will have
> the checks enforced.
>
Makes sense. We can enforce it in the future.
> The same mask is used for global and per queue settings.
>
Seems reasonable to me. It is unlikely that per-queue and global
settings would ever be different.
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> include/linux/ethtool.h | 45 +++++++++++++++++++++++++++--
> net/ethtool/ioctl.c | 63 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 105 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index 23373978cb3c..3c7328f02ba3 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -177,8 +177,44 @@ void ethtool_convert_legacy_u32_to_link_mode(unsigned long *dst,
> bool ethtool_convert_link_mode_to_legacy_u32(u32 *legacy_u32,
> const unsigned long *src);
>
> +#define ETHTOOL_COALESCE_RX_USECS BIT(0)
> +#define ETHTOOL_COALESCE_RX_MAX_FRAMES BIT(1)
> +#define ETHTOOL_COALESCE_RX_USECS_IRQ BIT(2)
> +#define ETHTOOL_COALESCE_RX_MAX_FRAMES_IRQ BIT(3)
> +#define ETHTOOL_COALESCE_TX_USECS BIT(4)
> +#define ETHTOOL_COALESCE_TX_MAX_FRAMES BIT(5)
> +#define ETHTOOL_COALESCE_TX_USECS_IRQ BIT(6)
> +#define ETHTOOL_COALESCE_TX_MAX_FRAMES_IRQ BIT(7)
> +#define ETHTOOL_COALESCE_STATS_BLOCK_USECS BIT(8)
> +#define ETHTOOL_COALESCE_USE_ADAPTIVE_RX BIT(9)
> +#define ETHTOOL_COALESCE_USE_ADAPTIVE_TX BIT(10)
> +#define ETHTOOL_COALESCE_PKT_RATE_LOW BIT(11)
> +#define ETHTOOL_COALESCE_RX_USECS_LOW BIT(12)
> +#define ETHTOOL_COALESCE_RX_MAX_FRAMES_LOW BIT(13)
> +#define ETHTOOL_COALESCE_TX_USECS_LOW BIT(14)
> +#define ETHTOOL_COALESCE_TX_MAX_FRAMES_LOW BIT(15)
> +#define ETHTOOL_COALESCE_PKT_RATE_HIGH BIT(16)
> +#define ETHTOOL_COALESCE_RX_USECS_HIGH BIT(17)
> +#define ETHTOOL_COALESCE_RX_MAX_FRAMES_HIGH BIT(18)
> +#define ETHTOOL_COALESCE_TX_USECS_HIGH BIT(19)
> +#define ETHTOOL_COALESCE_TX_MAX_FRAMES_HIGH BIT(20)
> +#define ETHTOOL_COALESCE_RATE_SAMPLE_INTERVAL BIT(21)
> +
> +#define ETHTOOL_COALESCE_USECS \
> + (ETHTOOL_COALESCE_RX_USECS | ETHTOOL_COALESCE_TX_USECS)
> +#define ETHTOOL_COALESCE_MAX_FRAMES \
> + (ETHTOOL_COALESCE_RX_MAX_FRAMES | ETHTOOL_COALESCE_TX_MAX_FRAMES)
> +#define ETHTOOL_COALESCE_USECS_IRQ \
> + (ETHTOOL_COALESCE_RX_USECS_IRQ | ETHTOOL_COALESCE_TX_USECS_IRQ)
> +#define ETHTOOL_COALESCE_MAX_FRAMES_IRQ \
> + (ETHTOOL_COALESCE_RX_MAX_FRAMES_IRQ | \
> + ETHTOOL_COALESCE_TX_MAX_FRAMES_IRQ)
> +#define ETHTOOL_COALESCE_USE_ADAPTIVE \
> + (ETHTOOL_COALESCE_USE_ADAPTIVE_RX | ETHTOOL_COALESCE_USE_ADAPTIVE_TX)
> +
> /**
> * struct ethtool_ops - optional netdev operations
> + * @coalesce_types: supported types of interrupt coalescing.
> * @get_drvinfo: Report driver/device information. Should only set the
> * @driver, @version, @fw_version and @bus_info fields. If not
> * implemented, the @driver and @bus_info fields will be filled in
> @@ -207,8 +243,9 @@ bool ethtool_convert_link_mode_to_legacy_u32(u32 *legacy_u32,
> * or zero.
> * @get_coalesce: Get interrupt coalescing parameters. Returns a negative
> * error code or zero.
> - * @set_coalesce: Set interrupt coalescing parameters. Returns a negative
> - * error code or zero.
> + * @set_coalesce: Set interrupt coalescing parameters. Supported coalescing
> + * types should be set in @coalesce_types.
> + * Returns a negative error code or zero.
> * @get_ringparam: Report ring sizes
> * @set_ringparam: Set ring sizes. Returns a negative error code or zero.
> * @get_pauseparam: Report pause parameters
> @@ -292,7 +329,8 @@ bool ethtool_convert_link_mode_to_legacy_u32(u32 *legacy_u32,
> * @set_per_queue_coalesce: Set interrupt coalescing parameters per queue.
> * It must check that the given queue number is valid. If neither a RX nor
> * a TX queue has this number, return -EINVAL. If only a RX queue or a TX
> - * queue has this number, ignore the inapplicable fields.
> + * queue has this number, ignore the inapplicable fields. Supported
> + * coalescing types should be set in @coalesce_types.
> * Returns a negative error code or zero.
> * @get_link_ksettings: Get various device settings including Ethernet link
> * settings. The %cmd and %link_mode_masks_nwords fields should be
> @@ -323,6 +361,7 @@ bool ethtool_convert_link_mode_to_legacy_u32(u32 *legacy_u32,
> * of the generic netdev features interface.
> */
> struct ethtool_ops {
> + u32 coalesce_types;
It feels weird to me to put this data in ops, but I can't think of a
better place.
Thanks,
Jake
Powered by blists - more mailing lists