netdev - Re: [PATCH net-next v2 08/12] ice: let core reject the unsupported coalescing parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b2fccc27-36da-1637-b217-7bdd81207a99@intel.com>
Date:   Wed, 4 Mar 2020 13:20:00 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     mkubecek@...e.cz, thomas.lendacky@....com, benve@...co.com,
        _govind@....com, pkaustub@...co.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com, snelson@...sando.io,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jeffrey.t.kirsher@...el.com, alexander.h.duyck@...ux.intel.com,
        michael.chan@...adcom.com, saeedm@...lanox.com, leon@...nel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 08/12] ice: let core reject the unsupported
 coalescing parameters

On 3/3/2020 8:33 PM, Jakub Kicinski wrote:
> Set ethtool_ops->coalesce_types to let the core reject
> unsupported coalescing parameters.
> 
> This driver correctly rejects all unsupported parameters.
> As a side effect of these changes the info message about
> the bad parameter will no longer be printed. We also
> always reject the tx_coalesce_usecs_high param, even
> if the target queue pair does not have a TX queue.
> 

Sure. The extra messaging isn't really helpful, and we could make it
part of the extended ack message in ethtool core later for callers who
use the ethlink interface.

Always rejecting tx_coalesce_usecs_high makes sense to me, we don't
support it at all.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>