netdev - Re: [PATCH net-next 06/12] ionic: let core reject the unsupported coalescing parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <313a02b6-cdfe-0322-2e16-67f1901b6724@pensando.io>
Date:   Tue, 3 Mar 2020 20:22:50 -0800
From:   Shannon Nelson <snelson@...sando.io>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     mkubecek@...e.cz, thomas.lendacky@....com, benve@...co.com,
        _govind@....com, pkaustub@...co.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jeffrey.t.kirsher@...el.com, jacob.e.keller@...el.com,
        alexander.h.duyck@...ux.intel.com, michael.chan@...adcom.com,
        saeedm@...lanox.com, leon@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 06/12] ionic: let core reject the unsupported
 coalescing parameters

On 3/3/20 7:54 PM, Jakub Kicinski wrote:
> Set ethtool_ops->coalesce_types to let the core reject
> unsupported coalescing parameters.
>
> This driver correctly rejects all unsupported parameters.
> No functional changes.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Thanks!

Acked-by: Shannon Nelson <snelson@...sando.io>


> ---
>   .../ethernet/pensando/ionic/ionic_ethtool.c   | 23 +------------------
>   1 file changed, 1 insertion(+), 22 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index f778fff034f5..83ea35715533 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -412,28 +412,6 @@ static int ionic_set_coalesce(struct net_device *netdev,
>   	unsigned int i;
>   	u32 coal;
>   
> -	if (coalesce->rx_max_coalesced_frames ||
> -	    coalesce->rx_coalesce_usecs_irq ||
> -	    coalesce->rx_max_coalesced_frames_irq ||
> -	    coalesce->tx_max_coalesced_frames ||
> -	    coalesce->tx_coalesce_usecs_irq ||
> -	    coalesce->tx_max_coalesced_frames_irq ||
> -	    coalesce->stats_block_coalesce_usecs ||
> -	    coalesce->use_adaptive_rx_coalesce ||
> -	    coalesce->use_adaptive_tx_coalesce ||
> -	    coalesce->pkt_rate_low ||
> -	    coalesce->rx_coalesce_usecs_low ||
> -	    coalesce->rx_max_coalesced_frames_low ||
> -	    coalesce->tx_coalesce_usecs_low ||
> -	    coalesce->tx_max_coalesced_frames_low ||
> -	    coalesce->pkt_rate_high ||
> -	    coalesce->rx_coalesce_usecs_high ||
> -	    coalesce->rx_max_coalesced_frames_high ||
> -	    coalesce->tx_coalesce_usecs_high ||
> -	    coalesce->tx_max_coalesced_frames_high ||
> -	    coalesce->rate_sample_interval)
> -		return -EINVAL;
> -
>   	ident = &lif->ionic->ident;
>   	if (ident->dev.intr_coal_div == 0) {
>   		netdev_warn(netdev, "bad HW value in dev.intr_coal_div = %d\n",
> @@ -784,6 +762,7 @@ static int ionic_nway_reset(struct net_device *netdev)
>   }
>   
>   static const struct ethtool_ops ionic_ethtool_ops = {
> +	.coalesce_types = ETHTOOL_COALESCE_USECS,
>   	.get_drvinfo		= ionic_get_drvinfo,
>   	.get_regs_len		= ionic_get_regs_len,
>   	.get_regs		= ionic_get_regs,