netdev - Re: [PATCH net-next 08/12] ice: let core reject the unsupported coalescing parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200303202413.6a312c3b@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 3 Mar 2020 20:24:13 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     davem@...emloft.net
Cc:     mkubecek@...e.cz, thomas.lendacky@....com, benve@...co.com,
        _govind@....com, pkaustub@...co.com, peppe.cavallaro@...com,
        alexandre.torgue@...com, joabreu@...opsys.com, snelson@...sando.io,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jeffrey.t.kirsher@...el.com, jacob.e.keller@...el.com,
        alexander.h.duyck@...ux.intel.com, michael.chan@...adcom.com,
        saeedm@...lanox.com, leon@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 08/12] ice: let core reject the unsupported
 coalescing parameters

On Tue,  3 Mar 2020 19:54:57 -0800 Jakub Kicinski wrote:
> @@ -3817,6 +3761,9 @@ ice_get_module_eeprom(struct net_device *netdev,
>  }
>  
>  static const struct ethtool_ops ice_ethtool_ops = {
> +	.coalesce_types = ETHTOOL_COALESCE_USECS |
> +			  ETHTOOL_COALESCE_USE_ADAPTIVE_RX |

Triple checking now this should have been ETHTOOL_COALESCE_USE_ADAPTIVE,
as TX also works. Let me resend, sorry for the noise.. :(

> +			  ETHTOOL_COALESCE_RX_USECS_HIGH,
>  	.get_link_ksettings	= ice_get_link_ksettings,
>  	.set_link_ksettings	= ice_set_link_ksettings,
>  	.get_drvinfo		= ice_get_drvinfo,