netdev - Re: [PATCH net-next 0/10] net: dsa: improve serdes integration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Mar 2020 04:57:20 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Russell King - ARM Linux admin <linux@...linux.org.uk>
Cc:     Florian Fainelli <f.fainelli@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH net-next 0/10] net: dsa: improve serdes integration

Hi Russell

> I will try to figure out which patch broke it.

ommit e67b45adefa8d43c68560906f3955845a5ee14d8 (HEAD)
Author: Russell King <rmk+kernel@...linux.org.uk>
Date:   Thu Mar 5 12:42:26 2020 +0000

    net: dsa: mv88e6xxx: configure interface settings in mac_config
    
    Only configure the interface settings in mac_config(), leaving the
    speed and duplex settings to mac_link_up to deal with.

Maybe:


+       /* FIXME: should we force the link down here - but if we do, how
+        * do we restore the link force/unforce state? The driver layering
+        * gets in the way.
+        */

???

	Andrew