netdev - Re: [PATCH net] net: nfc: fix bounds checking bugs on "pipe"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200305.213321.1243150631582322410.davem@davemloft.net>
Date:   Thu, 05 Mar 2020 21:33:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dan.carpenter@...cle.com
Cc:     christophe.ricard@...il.com, kuba@...nel.org,
        gregkh@...uxfoundation.org, kstewart@...uxfoundation.org,
        allison@...utok.net, netdev@...r.kernel.org, surenb@...gle.com,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: nfc: fix bounds checking bugs on "pipe"

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 4 Mar 2020 17:24:31 +0300

> This is similar to commit 674d9de02aa7 ("NFC: Fix possible memory
> corruption when handling SHDLC I-Frame commands") and commit d7ee81ad09f0
> ("NFC: nci: Add some bounds checking in nci_hci_cmd_received()") which
> added range checks on "pipe".
> 
> The "pipe" variable comes skb->data[0] in nfc_hci_msg_rx_work().
> It's in the 0-255 range.  We're using it as the array index into the
> hdev->pipes[] array which has NFC_HCI_MAX_PIPES (128) members.
> 
> Fixes: 118278f20aa8 ("NFC: hci: Add pipes table to reference them with a tuple {gate, host}")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied and queued up for -stable, thanks Dan.