netdev - Re: [PATCH net v2] mptcp: always include dack if possible.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200305.213514.1337555425416659597.davem@davemloft.net>
Date:   Thu, 05 Mar 2020 21:35:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, mathew.j.martineau@...ux.intel.com,
        matthieu.baerts@...sares.net, cpaasch@...le.com
Subject: Re: [PATCH net v2] mptcp: always include dack if possible.

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed,  4 Mar 2020 16:51:07 +0100

> Currently passive MPTCP socket can skip including the DACK
> option - if the peer sends data before accept() completes.
> 
> The above happens because the msk 'can_ack' flag is set
> only after the accept() call.
> 
> Such missing DACK option may cause - as per RFC spec -
> unwanted fallback to TCP.
> 
> This change addresses the issue using the key material
> available in the current subflow, if any, to create a suitable
> dack option when msk ack seq is not yet available.
> 
> v1 -> v2:
>  - adavance the generated ack after the initial MPC packet
> 
> Fixes: d22f4988ffec ("mptcp: process MP_CAPABLE data option")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, thank you.