netdev - Re: [PATCH net-next 3/7] tun: reject unsupported coalescing params

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Mar 2020 17:33:16 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     jdike@...toit.com, richard@....at, anton.ivanov@...bridgegreys.com,
        linux-um@...ts.infradead.org, dledford@...hat.com, jgg@...pe.ca,
        leon@...nel.org, linux-rdma@...r.kernel.org, edumazet@...gle.com,
        mkubecek@...e.cz, hayeswang@...ltek.com, doshir@...are.com,
        pv-drivers@...are.com, manishc@...vell.com,
        GR-Linux-NIC-Dev@...vell.com, gregkh@...uxfoundation.org,
        merez@...eaurora.org, kvalo@...eaurora.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/7] tun: reject unsupported coalescing params


On 2020/3/6 上午9:05, Jakub Kicinski wrote:
> Set ethtool_ops->supported_coalesce_params to let
> the core reject unsupported coalescing parameters.
>
> This driver did not previously reject unsupported parameters.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>   drivers/net/tun.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/tun.c b/drivers/net/tun.c
> index 79f248cb282d..9e8f23519e82 100644
> --- a/drivers/net/tun.c
> +++ b/drivers/net/tun.c
> @@ -3597,6 +3597,7 @@ static int tun_set_coalesce(struct net_device *dev,
>   }
>   
>   static const struct ethtool_ops tun_ethtool_ops = {
> +	.supported_coalesce_params = ETHTOOL_COALESCE_RX_MAX_FRAMES,
>   	.get_drvinfo	= tun_get_drvinfo,
>   	.get_msglevel	= tun_get_msglevel,
>   	.set_msglevel	= tun_set_msglevel,


Acked-by: Jason Wang <jasowang@...hat.com>