netdev - Re: [PATCH net] ibmvnic: Do not process device remove during device reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 09 Mar 2020 18:04:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     julietk@...ux.vnet.ibm.com
Cc:     netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        tlfalcon@...ux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Do not process device remove during
 device reset

From: Juliet Kim <julietk@...ux.vnet.ibm.com>
Date: Mon,  9 Mar 2020 19:02:04 -0500

> diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
> index c75239d8820f..7ef1ae0d49bc 100644
> --- a/drivers/net/ethernet/ibm/ibmvnic.c
> +++ b/drivers/net/ethernet/ibm/ibmvnic.c
> @@ -2144,6 +2144,8 @@ static void __ibmvnic_reset(struct work_struct *work)
>  	struct ibmvnic_adapter *adapter;
>  	u32 reset_state;
>  	int rc = 0;
> +	unsigned long flags;
> +	bool saved_state = false;

Please preserve the reverse christmas tree ordering of local variables.

Thank you.