netdev - Re: 2baecda bareudp: remove unnecessary udp_encap_enable() in bareudp_socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 09 Mar 2020 18:05:04 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     martin.varghese@...ia.com
Cc:     ap420073@...il.com, netdev@...r.kernel.org,
        martinvarghesenokia@...il.com
Subject: Re: 2baecda bareudp: remove unnecessary udp_encap_enable() in
 bareudp_socket_create()

From: "Varghese, Martin (Nokia - IN/Bangalore)" <martin.varghese@...ia.com>
Date: Tue, 10 Mar 2020 01:03:49 +0000

> HI Taehee Yoo & David,
> 
> The commit "2baecda bareudp: remove unnecessary udp_encap_enable() in bareudp_socket_create()" breaks the receive handler  of  bareudp device.
> setup_udp_tunnel_sock does not call udp_encap_enable() if the socket is ipv6. In bareudp v6 socket is used to receive v4 traffic also.
> Please let me know if I need to submit a patch again to put back the below lines
> 
> if (sock->sk->sk_family == AF_INET6)
>              udp_encap_enable();

So submit a fix.